Switch to R_getRegisteredNamespace #1469
Merged
eddelbuettel merged 2 commits intomasterfrom Apr 7, 2026
Merged
Conversation
eddelbuettel
changed the title
eddelbuettel
changed the title
Member
|
Moving the conditional from 4.5.0 to 4.6.0 for |
Member
Author
|
Not for checking Rcpp itself. That may have been a 'during development of 4.6.0' change too. |
eddelbuettel
force-pushed
the
bugfix/issue1468
branch
from
286478d to
5bbfb02
Compare
Member
Author
|
Rebasing now after your merge. And indeed while that now works for 4.5.3 and R-devel it bites with the older stuff. Will have to add another |
eddelbuettel
force-pushed
the
bugfix/issue1468
branch
from
5bbfb02 to
996f83b
Compare
Enchufa2
approved these changes
Apr 5, 2026
Member
Author
|
Behaves locally under R 4.4.3, R 4.5.3 and R 4.7.0 so into reverse dependency checking it goes, first updating the machine to current CRAN and then we'll roll for the 2 1/2 or whatever it takes days. |
Member
Author
|
This worked out fine, result of reverse depends committed here So ... merging and on to re-running the updated previous one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1468
R-devel (very recently) added
R_getRegisteredNamespace()allowing a lookup with in namespace with requiring theR_NamespaceRegistrysymbol which is retired.This minimal PR adjusts accordingly in one spot, and protects the condition by also selecting on the SVN commit number as the (automated) R-devel build we use in CI has not yet caught up.
Checklist
R CMD checkstill passes all tests